From 4d1c998ec0be227fb038c21c0195e33a9b34457d Mon Sep 17 00:00:00 2001 From: Yoni Rabkin Date: Mon, 3 May 2021 12:20:55 -0400 Subject: Clean: emms-track-file-p replaces eq file type checks There were about 10 checks throughout the code checking if a track is a file type. File type tracks are specific enough for a predicate function. Add: EMMS warning if no tagging program for audio file type Warn the user when there is no tag writing program available to EMMS for modifying the actual audio files. Current behavior allows the tags to be edited, saved to the EMMS cache db, and then silently skips past the part where the metadata would be applied to the file itself. The changes here prevent the user from even opening the editor for a file that has no tag writing program configured. This can be overridden with the prefix arg when user wants to edit the tags anyway, knowing they will only be saved in the emms-cache-db and not written to the source audio files. Patch by Grant Shangreaux --- doc/emms.texinfo | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'doc') diff --git a/doc/emms.texinfo b/doc/emms.texinfo index 77c27b2..d0e4570 100644 --- a/doc/emms.texinfo +++ b/doc/emms.texinfo @@ -1669,7 +1669,7 @@ from @file{emms-player-simple.el} @lisp (defun emms-mpg321-remote-playablep (track) "Return non-nil when we can play this track." - (and (eq 'file (emms-track-type track)) + (and (emms-track-file-p track) @end lisp @noindent -- cgit v1.2.3