Haddock with an org backend (haddorg). https://g.ypei.me/haddock.git/atom?h=ghc-9.2 2022-05-07T15:42:08+00:00 2022-05-07T15:42:08+00:00 Jade Lovelace software@lfcode.ca 2022-05-07T15:42:08+00:00 urn:sha1:ab53ccf089ea703b767581ac14be0f6c78a7678a Fixes #1481. There were two bugs in this: * We were assuming that we were always getting a relative path to the module in question, while Nix gives us file:// URLs sometimes. This change checks for those and stops prepending `..` to them. * We were not linking to the file under the module. This seems to have been a regression introduced by #977. That is, the URLs were going to something like file:///nix/store/3bwbsy0llxxn1pixx3ll02alln56ivxy-ghc-9.0.2-doc/share/doc/ghc/html/libraries/base-4.15.1.0/src which does not have the appropriate HTML file or fragment for the item in question at the end. There is a remaining instance of the latter bug, but not in the hyperlinker: the source links to items reexported from other modules are also not including the correct file name. e.g. the reexport of Entity in esqueleto, from persistent. NOTE: This needs to get tested with relative-path located modules. It seems correct for Nix based on my testing. Testing strategy: ``` nix-shell '<nixpkgs>' --pure -A haskell.packages.ghc922.aeson mkdir /tmp/aesonbuild && cd /tmp/aesonbuild export out=/tmp/aesonbuild/out genericBuild ln -sf $HOME/co/haddock/haddock-api/resources . ./Setup haddock --with-haddock=$HOME/path/to/haddock/exec --hyperlink-source ``` 2022-05-03T11:34:04+00:00 Phil de Joux philderbeast@gmail.com 2022-05-03T11:34:04+00:00 urn:sha1:bc0f2d6c1bfd331a9426fa9a92288444178267b1 2022-04-06T15:47:57+00:00 askeblad 74082607+askeblad@users.noreply.github.com 2022-04-06T15:47:57+00:00 urn:sha1:a127bb256ec411b2e78edba21299c5dabba3b847 2021-03-15T17:15:26+00:00 Alan Zimmerman alan.zimm@gmail.com 2020-04-18T17:37:38+00:00 urn:sha1:6173eeaa1608a4325ecd005feec05d3ab4e9323f As landed via https://gitlab.haskell.org/ghc/ghc/-/merge_requests/2418 2021-03-06T14:55:03+00:00 Shayne Fletcher shayne@shaynefletcher.org 2021-03-06T14:55:03+00:00 urn:sha1:0bf811ba98af90f852066734977aacb898ba8e69 2021-02-06T16:53:31+00:00 Ben Gamari ben@smart-cactus.org 2021-02-05T02:49:05+00:00 urn:sha1:bf8ba2525e95319bdbcfc81d06448b646eba3a57 2021-01-13T23:39:25+00:00 Ben Gamari ben@smart-cactus.org 2021-01-06T00:30:24+00:00 urn:sha1:e1230ede3d1c77a6916e318aefcd47829e56035c 2021-01-05T21:14:31+00:00 Ben Gamari ben@smart-cactus.org 2021-01-05T20:54:42+00:00 urn:sha1:1e56f63c3197e7ca1c1e506e083c2bad25d08793 2020-12-19T10:17:19+00:00 tomjaguarpaw tom-github.com@jaguarpaw.co.uk 2020-12-10T18:01:41+00:00 urn:sha1:beafcacfd0fc3d447d461a2be3378e50ef77d9c0 because they will be soon be added to -Wall. See https://gitlab.haskell.org/ghc/ghc/-/issues/15656 2020-12-15T20:13:30+00:00 Ben Gamari ben@smart-cactus.org 2020-12-15T20:13:30+00:00 urn:sha1:46c3db2460cea396fae525f4b9d8f40c34c0680e As this does not build on GHC `master`. This reverts commit 7936692badfe38f23ae95b51fb7bd7c2ff7e9bce.