From 3ab18cf06ae9392eab1349675dab8a177f1412da Mon Sep 17 00:00:00 2001
From: Mike Pilgrem <mpilgrem@users.noreply.github.com>
Date: Wed, 13 Nov 2019 21:43:03 +0000
Subject: Fix #783 Don't show button if --quickjump not present

---
 haddock-api/resources/html/js-src/quick-jump.tsx | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

(limited to 'haddock-api/resources/html/js-src')

diff --git a/haddock-api/resources/html/js-src/quick-jump.tsx b/haddock-api/resources/html/js-src/quick-jump.tsx
index 20ff8e15..ef02cbd2 100644
--- a/haddock-api/resources/html/js-src/quick-jump.tsx
+++ b/haddock-api/resources/html/js-src/quick-jump.tsx
@@ -45,11 +45,12 @@ class PageMenuButton extends Component<any, any> {
 
 }
 
-function addSearchPageMenuButton(action: () => void) {
-  const pageMenu = document.querySelector('#page-menu') as HTMLUListElement;
-  const dummy = document.createElement('li');
-  pageMenu.insertBefore(dummy, pageMenu.firstChild);
-  preact.render(<PageMenuButton onClick={action} title="Quick Jump" />, pageMenu, dummy);
+function addSearchPageMenuButton(quickJumpButton: HTMLLIElement) {
+  const showHide = function(action: () => void) {
+    const pageMenu = document.querySelector('#page-menu') as HTMLUListElement;
+    preact.render(<PageMenuButton onClick={action} title="Quick Jump" />, pageMenu, quickJumpButton);
+  };
+  return showHide;
 }
 
 // -------------------------------------------------------------------------- //
@@ -410,10 +411,14 @@ function NoResultsMsg(props: { searchString: string }) {
 }
 
 export function init(docBaseUrl?: string, showHide?: (action: () => void) => void) {
-  preact.render(
-    <QuickJump baseUrl={docBaseUrl || "."} showHideTrigger={showHide || addSearchPageMenuButton} />,
-    document.body
-  );
+  // A <li> element with this id should exist if --quickjump was set
+  const quickJumpButton = document.getElementById('quick-jump-button');
+  if (quickJumpButton)
+    preact.render(
+      <QuickJump baseUrl={docBaseUrl || "."} showHideTrigger={showHide ||
+        addSearchPageMenuButton(quickJumpButton as HTMLLIElement)} />,
+      document.body
+    );
 }
 
 // export to global object
-- 
cgit v1.2.3