From eb372d366b1896dba3274200d9a6992b7e2a18ff Mon Sep 17 00:00:00 2001 From: Ruben Rodriguez Date: Fri, 11 May 2018 13:50:22 -0400 Subject: Prevent evaluation of external scripts, as they are always nontrivial --- main_background.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'main_background.js') diff --git a/main_background.js b/main_background.js index 7a856b8..de24a4a 100644 --- a/main_background.js +++ b/main_background.js @@ -875,7 +875,10 @@ function license_read(script_src, name){ return [true,edited_src,reason_text]; } if(matches == null){ - nontrivial_status = evaluate(unedited_src,name); + if (external) + return [false,edited_src,"External script with no known license."]; + else + nontrivial_status = evaluate(unedited_src,name); if(nontrivial_status[0] == true){ parts_accepted = true; edited_src += unedited_src; @@ -903,7 +906,10 @@ function license_read(script_src, name){ // sponge console.log("before:"); console.log(before); - nontrivial_status = evaluate(before,name); + if (external) + nontrivial_status = [true, "External script with no known license"] + else + nontrivial_status = evaluate(before,name); if(nontrivial_status[0] == true){ parts_accepted = true; edited_src += before; -- cgit v1.2.3