From 19cadf0137cfaefb5012fd62611397129752761a Mon Sep 17 00:00:00 2001 From: Yuchen Pei Date: Tue, 27 Jul 2021 14:10:50 +1000 Subject: bugfix: moved side effects of add props to only when ticket non-nil --- rt-liberation-org.el | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/rt-liberation-org.el b/rt-liberation-org.el index 8db9a81..0943774 100644 --- a/rt-liberation-org.el +++ b/rt-liberation-org.el @@ -49,19 +49,18 @@ (defun rt-org-store-link () "Stores an rt link in ticket-browser mode." (require 'rt-liberation) - (let* ( - (ticket (or (get-text-property (point) 'rt-ticket) - rt-liber-ticket-local - )) - (link (concat "rt:id:" (rt-liber-ticket-id-only ticket))) - (subject (cdr (assoc "Subject" ticket))) + (let ((ticket (or (get-text-property (point) 'rt-ticket) + rt-liber-ticket-local))) + (when ticket + (let ( + (link (concat "rt:id:" (rt-liber-ticket-id-only ticket))) + (subject (cdr (assoc "Subject" ticket))) + ) + (org-link-add-props + :link link + :description subject ) - (org-link-add-props - :link link - :description subject - ) - (when ticket link) - )) + link)))) ;; org-add-link-type is obsolete as of org-mode 9. Instead we will use the ;; org-link-set-parameters method -- cgit v1.2.3