From d0eba2546a559922a53b59de44e7946b9d6b7c84 Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Mon, 7 May 2018 22:00:30 +0900
Subject: addbookmark command

---
 src/background/actions/command.js | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

(limited to 'src/background/actions')

diff --git a/src/background/actions/command.js b/src/background/actions/command.js
index 2f7305a..e46a97e 100644
--- a/src/background/actions/command.js
+++ b/src/background/actions/command.js
@@ -1,5 +1,6 @@
 import actions from '../actions';
 import * as tabs from '../shared/tabs';
+import * as bookmarks from '../shared/bookmarks';
 import * as parsers from 'shared/commands/parsers';
 import * as properties from 'shared/settings/properties';
 
@@ -39,6 +40,14 @@ const bufferCommand = (keywords) => {
   });
 };
 
+const addBookmarkCommand = (tab, args) => {
+  if (!args[0]) {
+    return Promise.resolve();
+  }
+
+  return bookmarks.create(args[0], tab.url);
+};
+
 const setCommand = (args) => {
   if (!args[0]) {
     return Promise.resolve();
@@ -52,7 +61,7 @@ const setCommand = (args) => {
   };
 };
 
-const exec = (line, settings) => {
+const exec = (tab, line, settings) => {
   let [name, args] = parsers.parseCommandLine(line);
 
   switch (name) {
@@ -68,6 +77,8 @@ const exec = (line, settings) => {
   case 'b':
   case 'buffer':
     return bufferCommand(args);
+  case 'addbookmark':
+    return addBookmarkCommand(tab, args);
   case 'set':
     return setCommand(args);
   case '':
-- 
cgit v1.2.3


From 53c3ddab2e0efa656ab04726a85df04bb899f4d8 Mon Sep 17 00:00:00 2001
From: Shin'ya Ueoka <ueokande@i-beam.org>
Date: Tue, 8 May 2018 21:36:58 +0900
Subject: Fix bookmark

---
 src/background/actions/command.js | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

(limited to 'src/background/actions')

diff --git a/src/background/actions/command.js b/src/background/actions/command.js
index e46a97e..be742cd 100644
--- a/src/background/actions/command.js
+++ b/src/background/actions/command.js
@@ -1,3 +1,4 @@
+import messages from 'shared/messages';
 import actions from '../actions';
 import * as tabs from '../shared/tabs';
 import * as bookmarks from '../shared/bookmarks';
@@ -45,7 +46,7 @@ const addBookmarkCommand = (tab, args) => {
     return Promise.resolve();
   }
 
-  return bookmarks.create(args[0], tab.url);
+  return bookmarks.create(args.join(' '), tab.url);
 };
 
 const setCommand = (args) => {
@@ -78,7 +79,18 @@ const exec = (tab, line, settings) => {
   case 'buffer':
     return bufferCommand(args);
   case 'addbookmark':
-    return addBookmarkCommand(tab, args);
+    return addBookmarkCommand(tab, args).then((item) => {
+      if (!item) {
+        return browser.tabs.sendMessage(tab.id, {
+          type: messages.CONSOLE_SHOW_ERROR,
+          text: 'Could not create a bookmark',
+        });
+      }
+      return browser.tabs.sendMessage(tab.id, {
+        type: messages.CONSOLE_SHOW_INFO,
+        text: 'Saved current page: ' + item.url,
+      });
+    });
   case 'set':
     return setCommand(args);
   case '':
-- 
cgit v1.2.3