From 0f9bcbd395dd0051e1bb8b64adbcb9b354101a81 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 9 Oct 2017 20:44:14 +0900 Subject: fix degrate --- src/background/components/background.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/background/components/background.js b/src/background/components/background.js index 06b6900..266ad64 100644 --- a/src/background/components/background.js +++ b/src/background/components/background.js @@ -43,7 +43,7 @@ export default class BackgroundComponent { type: messages.CONSOLE_HIDE_COMMAND, }); case messages.CONSOLE_ENTERED: - return commands.exec(message.text, this.settings).catch((e) => { + return commands.exec(message.text, this.settings.value).catch((e) => { return browser.tabs.sendMessage(sender.tab.id, { type: messages.CONSOLE_SHOW_ERROR, text: e.message, @@ -52,7 +52,7 @@ export default class BackgroundComponent { case messages.SETTINGS_QUERY: return Promise.resolve(this.store.getState().value); case messages.CONSOLE_QUERY_COMPLETIONS: - return commands.complete(message.text, this.settings); + return commands.complete(message.text, this.settings.value); case messages.SETTINGS_RELOAD: this.store.dispatch(settingsActions.load()); return this.broadcastSettingsChanged(); -- cgit v1.2.3 From 36963b1b8b595e0c5959ec4a2683e869008acebd Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 9 Oct 2017 20:54:53 +0900 Subject: change tabs.prev/tabs.next default keymap --- src/shared/default-settings.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/shared/default-settings.js b/src/shared/default-settings.js index f287b7a..8db7727 100644 --- a/src/shared/default-settings.js +++ b/src/shared/default-settings.js @@ -24,8 +24,8 @@ export default { "$": { "type": "scroll.end" }, "d": { "type": "tabs.close" }, "u": { "type": "tabs.reopen" }, - "h": { "type": "tabs.prev", "count": 1 }, - "l": { "type": "tabs.next", "count": 1 }, + "K": { "type": "tabs.prev", "count": 1 }, + "J": { "type": "tabs.next", "count": 1 }, "r": { "type": "tabs.reload", "cache": false }, "R": { "type": "tabs.reload", "cache": true }, "zi": { "type": "zoom.in" }, -- cgit v1.2.3 From 8c84930ca3ca673ca2b6afa8973b2de5f0dc9cb3 Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 9 Oct 2017 21:00:26 +0900 Subject: scroll horizonally --- src/content/actions/operation.js | 6 ++++-- src/content/scrolls.js | 16 ++++++++++++---- src/shared/default-settings.js | 6 ++++-- src/shared/operations.js | 3 ++- 4 files changed, 22 insertions(+), 9 deletions(-) (limited to 'src') diff --git a/src/content/actions/operation.js b/src/content/actions/operation.js index 0d5088b..1302404 100644 --- a/src/content/actions/operation.js +++ b/src/content/actions/operation.js @@ -8,8 +8,10 @@ import * as consoleFrames from 'content/console-frames'; const exec = (operation) => { switch (operation.type) { - case operations.SCROLL_LINES: - return scrolls.scrollLines(window, operation.count); + case operations.SCROLL_VERTICALLY: + return scrolls.scrollVertically(window, operation.count); + case operations.SCROLL_HORIZONALLY: + return scrolls.scrollHorizonally(window, operation.count); case operations.SCROLL_PAGES: return scrolls.scrollPages(window, operation.count); case operations.SCROLL_TOP: diff --git a/src/content/scrolls.js b/src/content/scrolls.js index b1cea6f..90bcc54 100644 --- a/src/content/scrolls.js +++ b/src/content/scrolls.js @@ -1,8 +1,15 @@ -const SCROLL_DELTA = 48; +const SCROLL_DELTA_X = 48; +const SCROLL_DELTA_Y = 48; -const scrollLines = (page, count) => { +const scrollVertically = (page, count) => { let x = page.scrollX; - let y = page.scrollY + SCROLL_DELTA * count; + let y = page.scrollY + SCROLL_DELTA_X * count; + page.scrollTo(x, y); +}; + +const scrollHorizonally = (page, count) => { + let x = page.scrollX + SCROLL_DELTA_Y * count; + let y = page.scrollY; page.scrollTo(x, y); }; @@ -38,5 +45,6 @@ const scrollRight = (page) => { }; export { - scrollLines, scrollPages, scrollTop, scrollBottom, scrollLeft, scrollRight + scrollVertically, scrollHorizonally, scrollPages, + scrollTop, scrollBottom, scrollLeft, scrollRight }; diff --git a/src/shared/default-settings.js b/src/shared/default-settings.js index 8db7727..ceacb50 100644 --- a/src/shared/default-settings.js +++ b/src/shared/default-settings.js @@ -11,8 +11,10 @@ export default { "w": { "type": "command.show.winopen", "alter": false }, "W": { "type": "command.show.winopen", "alter": true }, "b": { "type": "command.show.buffer" }, - "k": { "type": "scroll.lines", "count": -1 }, - "j": { "type": "scroll.lines", "count": 1 }, + "k": { "type": "scroll.vertically", "count": -1 }, + "j": { "type": "scroll.vertically", "count": 1 }, + "h": { "type": "scroll.horizonally", "count": -1 }, + "l": { "type": "scroll.horizonally", "count": 1 }, "": { "type": "scroll.lines", "count": -1 }, "": { "type": "scroll.lines", "count": 1 }, "": { "type": "scroll.pages", "count": -0.5 }, diff --git a/src/shared/operations.js b/src/shared/operations.js index ca62716..0d2a381 100644 --- a/src/shared/operations.js +++ b/src/shared/operations.js @@ -7,7 +7,8 @@ export default { COMMAND_SHOW_BUFFER: 'command.show.buffer', // Scrolls - SCROLL_LINES: 'scroll.lines', + SCROLL_VERTICALLY: 'scroll.vertically', + SCROLL_HORIZONALLY: 'scroll.horizonally', SCROLL_PAGES: 'scroll.pages', SCROLL_TOP: 'scroll.top', SCROLL_BOTTOM: 'scroll.bottom', -- cgit v1.2.3 From cf36bf192ccbc6ffd175e4dd397b4a9140b7f28b Mon Sep 17 00:00:00 2001 From: Shin'ya Ueoka Date: Mon, 9 Oct 2017 21:01:22 +0900 Subject: fix method name --- src/content/actions/operation.js | 4 ++-- src/content/scrolls.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/content/actions/operation.js b/src/content/actions/operation.js index 1302404..9187514 100644 --- a/src/content/actions/operation.js +++ b/src/content/actions/operation.js @@ -19,9 +19,9 @@ const exec = (operation) => { case operations.SCROLL_BOTTOM: return scrolls.scrollBottom(window); case operations.SCROLL_HOME: - return scrolls.scrollLeft(window); + return scrolls.scrollHome(window); case operations.SCROLL_END: - return scrolls.scrollRight(window); + return scrolls.scrollEnd(window); case operations.FOLLOW_START: return followActions.enable(false); case operations.NAVIGATE_HISTORY_PREV: diff --git a/src/content/scrolls.js b/src/content/scrolls.js index 90bcc54..86ea554 100644 --- a/src/content/scrolls.js +++ b/src/content/scrolls.js @@ -32,13 +32,13 @@ const scrollBottom = (page) => { page.scrollTo(x, y); }; -const scrollLeft = (page) => { +const scrollHome = (page) => { let x = 0; let y = page.scrollY; page.scrollTo(x, y); }; -const scrollRight = (page) => { +const scrollEnd = (page) => { let x = page.scrollMaxX; let y = page.scrollY; page.scrollTo(x, y); @@ -46,5 +46,5 @@ const scrollRight = (page) => { export { scrollVertically, scrollHorizonally, scrollPages, - scrollTop, scrollBottom, scrollLeft, scrollRight + scrollTop, scrollBottom, scrollHome, scrollEnd }; -- cgit v1.2.3