| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were about 10 checks throughout the code checking if a track is a
file type. File type tracks are specific enough for a predicate function.
Add: EMMS warning if no tagging program for audio file type
Warn the user when there is no tag writing program available to EMMS
for modifying the actual audio files. Current behavior allows the tags
to be edited, saved to the EMMS cache db, and then silently skips past
the part where the metadata would be applied to the file itself.
The changes here prevent the user from even opening the editor for a
file that has no tag writing program configured. This can be
overridden with the prefix arg when user wants to edit the tags
anyway, knowing they will only be saved in the emms-cache-db and not
written to the source audio files.
Patch by Grant Shangreaux
|
| |
|
| |
|
|
|
|
|
| |
Add a prefix argument to emms-cache-sync that will unconditionally
update all tracks in Emms cache.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* emms-mode-line.el (emms-mode-line-active-p): Rename to
`emms-mode-line-mode`.
(emms-mode-line-mode): New minor mode, extracted from `emms-mode-line`.
(emms-mode-line): Use it and mark as obsolete.
(emms-mode-line-enable, emms-mode-line-toggle): Adjust accordingly and
mark as obsolete as well.
(emms-mode-line-disable): Adjust accordingly.
* emms-playing-time.el (emms-playing-time-display-p): Rename to
`emms-playing-time-display-mode`.
(emms-playing-time-display-mode): New minor mode.
(emms-playing-time-p): Rename to `emms-playing-time-mode`.
(emms-playing-time-mode): New minor mode, extracted from
`emms-playing-time`.
(emms-playing-time): Use it and mark as obsolete.
(emms-playing-time-display-mode, emms-playing-time-display-mode):
Adjust and mark as obsolete.
* emms-setup.el (emms-all): Avoid the now obsolete functions.
patch by Stefan Monnier
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* emms-playlist-limit.el (emms-playlist-limit--limit-playlist): Simplify.
* emms-playing-time.el (emms-playing-time-display): Simplify.
* emms-player-mpv.el (emms-player-mpv-ipc-proc)
(emms-player-mpv-ipc-connect-command, emms-player-mpv-ipc-id)
(emms-player-mpv-ipc-stop-command)
(emms-player-mpv-event-connect-hook)
(emms-player-mpv-ipc-conn-emacs-26.1-workaround): Fit docstrings with
80 columns.
* emms-player-mpd.el (emms-player-mpd-ensure-process): Simplify `if`
with identical branches.
* emms-browser.el (emms-browser-run-mode-hooks): Simplify and move it
out of `eval-and-compile`.
(emms-browser-sort-cadr, emms-browser-sort-car): Add `debug` spec.
patch by Stefan Monnier
|
|
|
|
| |
patch by Stefan Monnier
|
|
|
|
|
|
|
|
| |
* emms.el: Require `nadvice` for compatibility with Emacs<24.4.
* emms-player-vlc.el (emms-player-vlc-start): Use `advice-add` rather
than `defadvice`.
patch by Stefan Monnier
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* jack.el: Enable lexical-binding.
* emms-playlist-limit.el (emms-playlist-limit--limit-playlist):
Use a closure.
* emms-player-mpg321-remote.el (emms-player-ignore-stop): Declare,
so as to fix a mis-compilation in `emms-player-mpg321-remote-notify-emms`.
* emms-last-played.el (emms-last-played-format-date): Use lexical binding.
* emms-browser.el (emms-browser-filter-only-dir)
(emms-browser-filter-only-type, emms-browser-filter-only-recent):
Return a closure.
Patch by Stefan Monnier
|
|
|
|
| |
Patch by Stefan Monnier
|
| |
|
|
|
|
| |
Patch by Stefan Monnier
|
|
|
|
|
|
| |
Also, remove some redundant leading `*` in defcustom docstrings
Patch by Stefan Monnier <monnier@iro.umontreal.ca>
|
| |
|
| |
|
| |
|
|
|
|
|
| |
It is now possible to easily hide the mode-line icon. The manual as been
updated with this information as well.
|
|
|
|
| |
make `emms-librefm-stream-tune-handshake-string' use authinfo as well
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| | |
|
| |
| |
| |
| | |
Tables look less cluttered than simple lists.
|
| |
| |
| |
| |
| |
| |
| | |
Include emms-info-native and use homogeneous style for all info
methods and their dependencies.
Also describe what info symbols are recognized by Emms.
|
| |
| |
| |
| |
| | |
Set emms-info-methods to emms-info-native and emms-info-cueinfo in
emms-all.
|
| | |
|
| | |
|
| |
| |
| |
| | |
emms-player-mpv-cmd-prog macro
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
This code is too smart for its own good and had left a lot of unused
lexical variables.
|
| | |
|
| |
| |
| |
| | |
Explicit ignore.
|
| | |
|
| | |
|
| |
| |
| |
| | |
Explicitly ignore variables that are implicitly not used.
|
| | |
|
| | |
|
| | |
|
| | |
|