aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* emms-(playing-time|mode-line).el: Use `define-minor-mode`Yoni Rabkin2021-04-293-27/+47
| | | | | | | | | | | | | | | | | | | | | | | | * emms-mode-line.el (emms-mode-line-active-p): Rename to `emms-mode-line-mode`. (emms-mode-line-mode): New minor mode, extracted from `emms-mode-line`. (emms-mode-line): Use it and mark as obsolete. (emms-mode-line-enable, emms-mode-line-toggle): Adjust accordingly and mark as obsolete as well. (emms-mode-line-disable): Adjust accordingly. * emms-playing-time.el (emms-playing-time-display-p): Rename to `emms-playing-time-display-mode`. (emms-playing-time-display-mode): New minor mode. (emms-playing-time-p): Rename to `emms-playing-time-mode`. (emms-playing-time-mode): New minor mode, extracted from `emms-playing-time`. (emms-playing-time): Use it and mark as obsolete. (emms-playing-time-display-mode, emms-playing-time-display-mode): Adjust and mark as obsolete. * emms-setup.el (emms-all): Avoid the now obsolete functions. patch by Stefan Monnier
* *.el: Minor improvements and simplificationsYoni Rabkin2021-04-297-146/+155
| | | | | | | | | | | | | | | | | | | | | | * emms-playlist-limit.el (emms-playlist-limit--limit-playlist): Simplify. * emms-playing-time.el (emms-playing-time-display): Simplify. * emms-player-mpv.el (emms-player-mpv-ipc-proc) (emms-player-mpv-ipc-connect-command, emms-player-mpv-ipc-id) (emms-player-mpv-ipc-stop-command) (emms-player-mpv-event-connect-hook) (emms-player-mpv-ipc-conn-emacs-26.1-workaround): Fit docstrings with 80 columns. * emms-player-mpd.el (emms-player-mpd-ensure-process): Simplify `if` with identical branches. * emms-browser.el (emms-browser-run-mode-hooks): Simplify and move it out of `eval-and-compile`. (emms-browser-sort-cadr, emms-browser-sort-car): Add `debug` spec. patch by Stefan Monnier
* * emms-player-mpv.el: use closureYoni Rabkin2021-04-291-2/+2
| | | | patch by Stefan Monnier
* *.el: Avoid the obsolete `defadvice` systemYoni Rabkin2021-04-293-8/+11
| | | | | | | | * emms.el: Require `nadvice` for compatibility with Emacs<24.4. * emms-player-vlc.el (emms-player-vlc-start): Use `advice-add` rather than `defadvice`. patch by Stefan Monnier
* *.el: Misc improvements and fixes w.r.t lexical bindingYoni Rabkin2021-04-276-28/+28
| | | | | | | | | | | | | | | | | | * jack.el: Enable lexical-binding. * emms-playlist-limit.el (emms-playlist-limit--limit-playlist): Use a closure. * emms-player-mpg321-remote.el (emms-player-ignore-stop): Declare, so as to fix a mis-compilation in `emms-player-mpg321-remote-notify-emms`. * emms-last-played.el (emms-last-played-format-date): Use lexical binding. * emms-browser.el (emms-browser-filter-only-dir) (emms-browser-filter-only-type, emms-browser-filter-only-recent): Return a closure. Patch by Stefan Monnier
* Replace `add-to-list' with `add-hook' where appropriateYoni Rabkin2021-04-213-7/+7
| | | | Patch by Stefan Monnier
* * Makefile: no longer neededYoni Rabkin2021-04-211-2/+0
|
* Change the function quoting style to help the compiler.Yoni Rabkin2021-04-2024-244/+245
| | | | Patch by Stefan Monnier
* *.el: Remove redundant `:group` argumentsYoni Rabkin2021-04-1724-286/+172
| | | | | | Also, remove some redundant leading `*` in defcustom docstrings Patch by Stefan Monnier <monnier@iro.umontreal.ca>
* no longer need to provide the compiled info and dir filesYoni Rabkin2021-04-172-4076/+0
|
* * doc/developer-release.txt:Yoni Rabkin2021-04-141-1/+1
|
* * emms.el: bump to version 7.1Yoni Rabkin2021-04-144-4/+9
|
* * emms-mode-line-icon.el: hiding icon made easyYoni Rabkin2021-04-073-26/+48
| | | | | It is now possible to easily hide the mode-line icon. The manual as been updated with this information as well.
* * emms-librefm-stream.el: authinfo for streamingYoni Rabkin2021-04-071-13/+11
| | | | make `emms-librefm-stream-tune-handshake-string' use authinfo as well
* * doc/developer-release.txt:Yoni Rabkin2021-04-051-2/+2
|
* * emms.el: version bumpYoni Rabkin2021-04-051-1/+1
|
* * NEWS: tell the people the news!Yoni Rabkin2021-04-051-0/+7
|
* * emms.info: updateYoni Rabkin2021-03-271-85/+93
|
* * doc/emms.texinfo: mention cache resetYoni Rabkin2021-03-271-3/+9
|
* * emms.info: new infoYoni Rabkin2021-03-101-153/+325
|
* Merge branch 'info-native'Petteri Hintsanen2021-03-101-101/+285
|\
| * Miscellaneous small fixes to manual chapter 13Petteri Hintsanen2021-03-101-17/+20
| |
| * Use two-column tables in manual chapter 13Petteri Hintsanen2021-03-101-78/+75
| | | | | | | | Tables look less cluttered than simple lists.
| * Rewrite manual Chapter 13 Track InformationPetteri Hintsanen2021-03-081-97/+281
| | | | | | | | | | | | | | Include emms-info-native and use homogeneous style for all info methods and their dependencies. Also describe what info symbols are recognized by Emms.
* | Set new default info methods in emms-allPetteri Hintsanen2021-03-101-7/+2
| | | | | | | | | | Set emms-info-methods to emms-info-native and emms-info-cueinfo in emms-all.
* | * emms-browser.el: add-to-list -> cl-pushnewYoni Rabkin2021-03-051-1/+1
| |
* | * emms-browser.el: fix unused lexical variables and argumentsYoni Rabkin2021-03-051-15/+11
| |
* | * emms-player-mplayer.el: lexical declaration, deprecate ↵Mike Kazantsev2021-03-041-14/+19
| | | | | | | | emms-player-mpv-cmd-prog macro
* | lexical declarationYoni Rabkin2021-03-0313-15/+15
| |
* | * emms-playlist-mode.el:Yoni Rabkin2021-03-031-3/+3
| |
* | * emms-playing-time.el: add lexical and fixYoni Rabkin2021-03-031-3/+3
| |
* | add lexical declarationsYoni Rabkin2021-03-032-2/+2
| |
* | * emms-player-simple.el: lexical declaration and fixYoni Rabkin2021-03-031-1/+2
| |
* | * emms-player-mplayer.el: lexical declarationYoni Rabkin2021-03-031-1/+1
| |
* | * emms-player-mpg321-remote.el: add lexical and fixYoni Rabkin2021-03-031-2/+6
| |
* | * emms-player-mpd.el: add lexical and fixYoni Rabkin2021-03-031-5/+16
| | | | | | | | | | This code is too smart for its own good and had left a lot of unused lexical variables.
* | * emms-mode-line-icon.el: add lexicalYoni Rabkin2021-03-031-1/+1
| |
* | * emms-mode-line.el: add lexical and fixYoni Rabkin2021-03-031-1/+2
| | | | | | | | Explicit ignore.
* | add lexical declarationsYoni Rabkin2021-03-033-3/+3
| |
* | * emms-librefm-stream.el: add lexical and fix warningsYoni Rabkin2021-03-021-26/+19
| |
* | * emms-librefm-scrobbler.el: add lexical declarationYoni Rabkin2021-03-021-1/+6
| | | | | | | | Explicitly ignore variables that are implicitly not used.
* | * emms-later-do.el: tell the compiler that we knowYoni Rabkin2021-03-021-1/+1
| |
* | * emms-later-do.el: add lexical declarationYoni Rabkin2021-03-021-1/+1
| |
* | Add lexical declarationsYoni Rabkin2021-03-023-3/+3
| |
* | * emms-info-mp3info.el: lexical declarationYoni Rabkin2021-03-021-1/+1
| |
* | * emms-info-metaflac.el: lexical declarationYoni Rabkin2021-03-021-1/+1
| |
* | * emms-info-libtag.el: lexical declarationYoni Rabkin2021-03-021-1/+1
| |
* | * emms-info.el: add lexical and remove unused lexical variableYoni Rabkin2021-03-021-3/+2
| |
* | * emms-i18n.el: calm down the compilerYoni Rabkin2021-03-021-1/+1
| |
* | * emms-i18n.el: lexical declarationYoni Rabkin2021-03-021-1/+1
| |