diff options
| author | Alan Zimmerman <alan.zimm@gmail.com> | 2015-07-26 22:19:40 +0200 |
|---|---|---|
| committer | Matthew Pickering <matthewtpickering@gmail.com> | 2015-12-14 15:14:06 +0000 |
| commit | 81653061d333a1e7d6024e132b1a72a947b9b0ab (patch) | |
| tree | 492ba1fefe07a364a7bcbc05057642fa84ff7d78 | |
| parent | 2d38f9b34a19b77f4260e8a0291156dace1d63fc (diff) | |
Replace (SourceText,FastString) with WithSourceText data type
Phab:D907 introduced SourceText for a number of data types, by replacing
FastString with (SourceText,FastString). Since this has an Outputable
instance, no warnings are generated when ppr is called on it, but
unexpected output is generated. See Phab:D1096 for an example of this.
Replace the (SourceText,FastString) tuples with a new data type
data WithSourceText = WithSourceText SourceText FastString
Trac ticket: #10692
| -rw-r--r-- | haddock-api/src/Haddock/Interface/Create.hs | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/haddock-api/src/Haddock/Interface/Create.hs b/haddock-api/src/Haddock/Interface/Create.hs index 8b4605a7..d8f49edc 100644 --- a/haddock-api/src/Haddock/Interface/Create.hs +++ b/haddock-api/src/Haddock/Interface/Create.hs @@ -48,6 +48,7 @@ import Bag import RdrName import TcRnTypes import FastString (concatFS) +import BasicTypes ( StringLiteral(..) ) import qualified Outputable as O -- | Use a 'TypecheckedModule' to produce an 'Interface'. @@ -164,7 +165,7 @@ mkAliasMap dflags mRenamedSource = return $ (lookupModuleDyn dflags (fmap Module.fsToPackageKey $ - fmap snd $ ideclPkgQual impDecl) + fmap sl_fs $ ideclPkgQual impDecl) (case ideclName impDecl of SrcLoc.L _ name -> name), alias)) impDecls @@ -200,8 +201,8 @@ moduleWarning dflags gre (WarnAll w) = Just $ parseWarning dflags gre w parseWarning :: DynFlags -> GlobalRdrEnv -> WarningTxt -> Doc Name parseWarning dflags gre w = force $ case w of - DeprecatedTxt _ msg -> format "Deprecated: " (concatFS $ map (snd . unLoc) msg) - WarningTxt _ msg -> format "Warning: " (concatFS $ map (snd . unLoc) msg) + DeprecatedTxt _ msg -> format "Deprecated: " (concatFS $ map (sl_fs . unLoc) msg) + WarningTxt _ msg -> format "Warning: " (concatFS $ map (sl_fs . unLoc) msg) where format x xs = DocWarning . DocParagraph . DocAppend (DocString x) . processDocString dflags gre $ HsDocString xs |