diff options
| author | David Waern <david.waern@gmail.com> | 2008-02-09 22:33:24 +0000 |
|---|---|---|
| committer | David Waern <david.waern@gmail.com> | 2008-02-09 22:33:24 +0000 |
| commit | 953a67e86fedb849eed06154fb59de2091bb148f (patch) | |
| tree | 49ad6da30d4062f6e52d46737f153af7fe2262b0 /src/Haddock/GHC/Utils.hs | |
| parent | 95352ca3832192a94697988c5979e258dc85003a (diff) | |
Change the representation of DocNames
Ross Paterson reported a bug where links would point to the defining module
instead of the "best" module for an identifier (e.g Int pointing to GHC.Base
instead of Data.Int). This patch fixes this problem by refactoring the way
renamed names are represented. Instead of representing them by:
> data DocName = Link Name | NoLink Name
they are now represented as such:
> data DocName = Documented Name Module | Undocumented Name
and the the link-env looks like this:
> type LinkEnv = Map Name Module
There are several reasons for this. First of all, the bug was caused by
changing the module part of Names during the renaming process, without changing
the Unique field. This caused names to be overwritten during the loading of
.haddock files (which caches names using the NameCache of the GHC session).
So we might create new Uniques during renaming to fix this (but I'm not
sure that would be problem-free). Instead, we just keep the Name and add the
Module where the name is best documented, since it can be useful to keep
the original Name around (for e.g. source-code location info and for users of
the Haddock API).
Also, the names Link/NoLink don't really make sense, since wether to use
links or not is entirely up to the users of DocName.
In the process of following this change into H.Backends.Html I removed the
assumption that binder names are Undocumented (which was just an unnecessary
assumption, the OccName is the only thing needed to render these). This will
probably make it possible to get rid of the renamer and replace it with a
traversal from SYB or Uniplate.
Since DocName has changed, InterfaceFile has changed so this patch also
increments the file-format version. No backwards-compatibility is implemented.
Diffstat (limited to 'src/Haddock/GHC/Utils.hs')
| -rw-r--r-- | src/Haddock/GHC/Utils.hs | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/Haddock/GHC/Utils.hs b/src/Haddock/GHC/Utils.hs index cfe0a83b..21c34fc5 100644 --- a/src/Haddock/GHC/Utils.hs +++ b/src/Haddock/GHC/Utils.hs @@ -61,9 +61,7 @@ instance (Outputable a, Outputable b) => Outputable (Map.Map a b) where -- misc -isNameSym n = isNameVarSym n || isNameConSym n -isNameVarSym = isLexVarSym . occNameFS . nameOccName -isNameConSym = isLexConSym . occNameFS . nameOccName +isNameSym = isSymOcc . nameOccName getMainDeclBinder :: HsDecl name -> Maybe name |