aboutsummaryrefslogtreecommitdiff
path: root/haddock-api/src/Haddock/GhcUtils.hs
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #1273 from hsyl20/wip/hsyl20/arrowsHécate Moonlight2021-01-141-1/+1
|\ | | | | Fix after binder collect changes
| * Fix after binder collect changesSylvain Henry2020-12-211-1/+1
| |
* | Abstract Monad for interface creationAlex Biehl2021-01-091-9/+0
| | | | | | | | | | | | | | | | | | | | I found that when running as a plugin the lookupName function (which runs in Ghc monad) does not work correctly from the typeCheckResultAction hook. Instead, we abstracted the monad used when creating interfaces, so that access to GHC session specific parts is explicit and so that the TcM can provide their (correct) implementation of lookupName.
* | Inline and fix getGADTConTypeGVladislav Zavialov2020-12-291-30/+0
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The getGADTConTypeG used HsRecTy, which is at odds with GHC issue #18782. I noticed that getGADTConTypeG was only used in the Hoogle backend. Interestingly, when handling H98 constructors, Hoogle converts RecCon to PrefixCon (see Haddock.Backends.Hoogle.ppCtor). So I changed getGADTConTypeG to handle RecConGADT in the same manner as PrefixConGADT, and after this simplification moved it into the 'where' clause of ppCtor, to the only place where it is used. The practical effect of this change is as follows. Consider this example: data TestH98 = T98 { bar::Int } data TestGADT where TG :: { foo :: Int } -> TestGADT Before this patch, haddock --hoogle used to produce: T98 :: Int -> TestH98 [TG] :: {foo :: Int} -> TestGADT Notice how the record syntax was discarded in T98 but not TG. With this patch, we always produce signatures without record syntax: T98 :: Int -> TestH98 [TG] :: Int -> TestGADT I suspect this might also be a bugfix, as currently Hoogle doesn't seem to render GADT record constructors properly.
* Enable two warnings (#1245) (#1268)tomjaguarpaw2020-12-191-0/+1
| | | | | | because they will be soon be added to -Wall. See https://gitlab.haskell.org/ghc/ghc/-/issues/15656
* Merge remote-tracking branch 'upstream/ghc-head' into ghc-headBen Gamari2020-12-151-1/+0
|\
| * Revert "Enable two warnings (#1245) (#1268)"Ben Gamari2020-12-151-1/+0
| | | | | | | | | | | | As this does not build on GHC `master`. This reverts commit 7936692badfe38f23ae95b51fb7bd7c2ff7e9bce.
* | Revert "Update for boxed rep"Ben Gamari2020-12-151-2/+2
|/ | | | This reverts commit 4ffb30d8b637ccebecc81ce610f0af451ac8088d.
* Update for boxed repAndrew Martin2020-12-141-2/+2
|
* Enable two warnings (#1245) (#1268)tomjaguarpaw2020-12-101-0/+1
| | | | | because they will be soon be added to -Wall. See https://gitlab.haskell.org/ghc/ghc/-/issues/15656
* Adapt to HsOuterTyVarBndrsRyan Scott2020-10-301-26/+50
| | | | | These changes accompany ghc/ghc!4107, which aims to be a fix for #16762.
* Adapt to HsConDecl{H98,GADT}Details splitRyan Scott2020-10-301-11/+6
| | | | Needed for GHC#18844.
* GHC.Driver.Types refactoring (#1242)Sylvain Henry2020-10-261-1/+0
|
* Match GHC, adding IsUnicodeSyntax field to HsFunTy and HsScaledAlan Zimmerman2020-10-191-3/+4
|
* Fix after Outputable refactoringSylvain Henry2020-08-051-1/+3
|
* Update for modular ping pongZubin Duggal2020-07-231-37/+25
|
* Use functions exported from HsToCoreZubin Duggal2020-06-211-41/+0
|
* Adapt Haddock to LinearTypesKrzysztof Gogolewski2020-06-171-13/+19
| | | | See ghc/ghc!852.
* Use HsForAllTelescope (GHC#18235)Ryan Scott2020-06-131-10/+22
|
* Changes for GHC#18191Ryan Scott2020-06-051-1/+4
| | | | See https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3337.
* Explicit Specificity Support for HaddockGert-Jan Bottu2020-05-201-9/+9
|
* add dependency on exceptions because GHC.Exception was boiled down (ghc #18075)Artem Pelenitsyn2020-05-031-5/+0
|
* Fix for GHC.Unit.* modulesSylvain Henry2020-04-271-2/+1
|
* Module structureSylvain Henry2020-04-241-5/+5
|
* Merge remote-tracking branch 'origin/ghc-head' into wip/ttg-con-patCale Gibbard2020-04-201-2/+2
|\
| * Module renamingSylvain Henry2020-04-101-2/+2
| |
* | Rename XCollectPat -> CollectPassCale Gibbard2020-04-141-2/+2
| |
* | Add instance of XCollectPat for DocNameICale Gibbard2020-04-141-1/+2
|/
* Make NoExtCon fields strictRyan Scott2020-04-071-13/+0
| | | | | These changes are a part of a fix for [GHC#17992](https://gitlab.haskell.org/ghc/ghc/issues/17992).
* Modules: TypesSylvain Henry2020-03-181-10/+10
|
* Modules: Core (#13009)Sylvain Henry2020-03-021-3/+3
|
* Modules: Driver (#13009)Sylvain Henry2020-02-191-2/+2
|
* Changes for GHC#17566Ryan Scott2020-01-251-2/+26
| | | | See https://gitlab.haskell.org/ghc/ghc/merge_requests/2469
* Fix after Iface modules renamingSylvain Henry2020-01-021-1/+1
|
* Remove HasSrcSpan (#17494)Vladislav Zavialov2019-11-281-2/+2
|
* Import isRuntimeRepVar from Type rather than TyCoRepBen Gamari2019-11-091-1/+2
| | | | isRuntimeRepVar is not longer exported from TyCoRep due to ghc#17441.
* Small change in to facilitate extended typed-holes (#1090)Matthías Páll Gissurarson2019-09-281-4/+4
| | | This change has no functional effect on haddock itself, it just changes one pattern to use `_ (` rather than `_(`, so that we may use `_(` as a token for extended typed-holes later.
* Changes for #15247Ryan Scott2019-07-031-35/+55
|
* Visible dependent quantification (#16326) changesRyan Scott2019-02-271-5/+6
|
* Match GHC changes for T16185Alec Theriault2019-02-221-3/+3
| | | | | | | `FunTy` now has an `AnonArgFlag` that indicates whether the arrow is a `t1 => t2` or `t1 -> t2`. This commit shouldn't change any functionality in Haddock.
* Miscellaneous improvements to `Convert` (#1020)Alec Theriault2019-02-031-1/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that Haddock is moving towards working entirely over `.hi` and `.hie` files, all declarations and types are going to be synthesized via the `Convert` module. In preparation for this change, here are a bunch of fixes to this module: * Add kind annotations to type variables in `forall`'s whose kind is not `Type`, unless the kind can be inferred from some later use of the variable. See `implicitForAll` and `noKindTyVars` in particular if you wish to dive into this. * Properly detect `HsQualTy` in `synifyType`. This is done by following suit with what GHC's `toIfaceTypeX` does and checking the first argument of `FunTy{} :: Type` to see if it classified as a given/wanted in the typechecker (see `isPredTy`). * Beef up the logic around figuring out when an explicit `forall` is needed. This includes: observing if any of the type variables will need kind signatures, if the inferred type variable order _without_ a forall will still match the one GHC claims, and some other small things. * Add some (not yet used) functionality for default levity polymorphic type signatures. This functionality similar to `fprint-explicit-runtime-reps`. Couple other smaller fixes only worth mentioning: * Show the family result signature only when it isn't `Type` * Fix rendering of implicit parameters in the LaTeX and Hoogle backends * Better handling of the return kind of polykinded H98 data declarations * Class decls produced by `tyThingToLHsDecl` now contain associated type defaults and default method signatures when appropriate * Filter out more `forall`'s in pattern synonyms
* Use `.hie` files for the Hyperlinker backend (#977)Alec Theriault2019-01-311-3/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # Summary This is a large architectural change to the Hyperlinker. * extract link (and now also type) information from `.hie` instead of doing ad-hoc SYB traversals of the `RenamedSource`. Also adds a superb type-on-hover feature (#715). * re-engineer the lexer to avoid needless string conversions. By going directly through GHC's `P` monad and taking bytestring slices, we avoid a ton of allocation and have better handling of position pragmas and CPP. In terms of performance, the Haddock side of things has gotten _much_ more efficient. Unfortunately, much of this is cancelled out by the increased GHC workload for generating `.hie` files. For the full set of boot libs (including `ghc`-the-library) * the sum of total time went down by 9-10% overall * the sum of total allocations went down by 6-7% # Motivation Haddock is moving towards working entirely over `.hi` and `.hie` files. This change means we no longer need the `RenamedSource` from `TypecheckedModule` (something which is _not_ in `.hi` files). # Details Along the way a bunch of things were fixed: * Cross package (and other) links are now more reliable (#496) * The lexer tries to recover from errors on every line (instead of at CPP boundaries) * `LINE`/`COLUMN` pragmas are taken into account * filter out zero length tokens before rendering * avoid recomputing the `ModuleName`-based `SrcMap` * remove the last use of `Documentation.Haddock.Utf8` (see #998) * restructure temporary folder logic for `.hi`/`.hie` model
* Visible kind application haddock updatemynguyen2018-12-301-0/+2
|
* Refactor names + unused functions (#982)Alec Theriault2018-12-171-15/+0
| | | | | | | This commit should not introduce any change in functionality! * consistently use `getOccString` to convert `Name`s to strings * compare names directly when possible (instead of comparing strings) * get rid of unused utility functions
* Fix warnings, accept outputAlec Theriault2018-12-121-2/+0
| | | | | | | * remove redundant imports (only brought to light due to recent work for improving redundant import detection) * fix a bug that was casuing exports to appear in reverse order * fix something in haddock-library that prevented compilation on old GHC's
* [TTG: Handling Source Locations] Foundation and PatShayan-Najd2018-11-231-3/+3
| | | | | | | | | | | Trac Issues #15495 This patch removes the ping-pong style from HsPat (only, for now), using the plan laid out at https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow/HandlingSourceLocations (solution A). - the class `HasSrcSpan`, and its functions (e.g., `cL` and `dL`), are introduced - some instances of `HasSrcSpan` are introduced - some constructors `L` are replaced with `cL` - some patterns `L` are replaced with `dL->L` view pattern - some type annotation are necessarily updated (e.g., `Pat p` --> `Pat (GhcPass p)`)
* Refactor handling of parens in types (#874)Alec Theriault2018-07-201-0/+96
| | | | | | | | | | | | | | | | | | | | | | | | * Fix type parenthesization in Hoogle backend Ported the logic in the HTML and LaTeX backends for adding in parens into something top-level in 'GhcUtil'. Calling that from the Hoogle backend fixes #873. * Remove parenthesizing logic from LaTeX and XHTML backends Now, the only times that parenthesis in types are added in any backend is through the explicit 'HsParTy' constructor. Precedence is also represented as its own datatype. * List out cases explicitly vs. catch-all * Fix printing of parens for QuantifiedConstraints The priority of printing 'forall' types was just one too high. Fixes #877. * Accept HTML output for quantified contexts test
* Match changes in GHC for #14259Alan Zimmerman2018-06-191-2/+2
|
* Match changes in GHC for TTGAlan Zimmerman2018-04-271-17/+27
|
* Match GHC for TTG implemented on HsBinds, D4581Alan Zimmerman2018-04-131-22/+22
|
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-11 12:48:31 +0000