aboutsummaryrefslogtreecommitdiff
path: root/haddock-api/src/Haddock/GhcUtils.hs
Commit message (Collapse)AuthorAgeFilesLines
* Miscellaneous improvements to `Convert` (#1020)Alec Theriault2019-02-031-1/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that Haddock is moving towards working entirely over `.hi` and `.hie` files, all declarations and types are going to be synthesized via the `Convert` module. In preparation for this change, here are a bunch of fixes to this module: * Add kind annotations to type variables in `forall`'s whose kind is not `Type`, unless the kind can be inferred from some later use of the variable. See `implicitForAll` and `noKindTyVars` in particular if you wish to dive into this. * Properly detect `HsQualTy` in `synifyType`. This is done by following suit with what GHC's `toIfaceTypeX` does and checking the first argument of `FunTy{} :: Type` to see if it classified as a given/wanted in the typechecker (see `isPredTy`). * Beef up the logic around figuring out when an explicit `forall` is needed. This includes: observing if any of the type variables will need kind signatures, if the inferred type variable order _without_ a forall will still match the one GHC claims, and some other small things. * Add some (not yet used) functionality for default levity polymorphic type signatures. This functionality similar to `fprint-explicit-runtime-reps`. Couple other smaller fixes only worth mentioning: * Show the family result signature only when it isn't `Type` * Fix rendering of implicit parameters in the LaTeX and Hoogle backends * Better handling of the return kind of polykinded H98 data declarations * Class decls produced by `tyThingToLHsDecl` now contain associated type defaults and default method signatures when appropriate * Filter out more `forall`'s in pattern synonyms
* Use `.hie` files for the Hyperlinker backend (#977)Alec Theriault2019-01-311-3/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # Summary This is a large architectural change to the Hyperlinker. * extract link (and now also type) information from `.hie` instead of doing ad-hoc SYB traversals of the `RenamedSource`. Also adds a superb type-on-hover feature (#715). * re-engineer the lexer to avoid needless string conversions. By going directly through GHC's `P` monad and taking bytestring slices, we avoid a ton of allocation and have better handling of position pragmas and CPP. In terms of performance, the Haddock side of things has gotten _much_ more efficient. Unfortunately, much of this is cancelled out by the increased GHC workload for generating `.hie` files. For the full set of boot libs (including `ghc`-the-library) * the sum of total time went down by 9-10% overall * the sum of total allocations went down by 6-7% # Motivation Haddock is moving towards working entirely over `.hi` and `.hie` files. This change means we no longer need the `RenamedSource` from `TypecheckedModule` (something which is _not_ in `.hi` files). # Details Along the way a bunch of things were fixed: * Cross package (and other) links are now more reliable (#496) * The lexer tries to recover from errors on every line (instead of at CPP boundaries) * `LINE`/`COLUMN` pragmas are taken into account * filter out zero length tokens before rendering * avoid recomputing the `ModuleName`-based `SrcMap` * remove the last use of `Documentation.Haddock.Utf8` (see #998) * restructure temporary folder logic for `.hi`/`.hie` model
* Visible kind application haddock updatemynguyen2018-12-301-0/+2
|
* Refactor names + unused functions (#982)Alec Theriault2018-12-171-15/+0
| | | | | | | This commit should not introduce any change in functionality! * consistently use `getOccString` to convert `Name`s to strings * compare names directly when possible (instead of comparing strings) * get rid of unused utility functions
* Fix warnings, accept outputAlec Theriault2018-12-121-2/+0
| | | | | | | * remove redundant imports (only brought to light due to recent work for improving redundant import detection) * fix a bug that was casuing exports to appear in reverse order * fix something in haddock-library that prevented compilation on old GHC's
* [TTG: Handling Source Locations] Foundation and PatShayan-Najd2018-11-231-3/+3
| | | | | | | | | | | Trac Issues #15495 This patch removes the ping-pong style from HsPat (only, for now), using the plan laid out at https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow/HandlingSourceLocations (solution A). - the class `HasSrcSpan`, and its functions (e.g., `cL` and `dL`), are introduced - some instances of `HasSrcSpan` are introduced - some constructors `L` are replaced with `cL` - some patterns `L` are replaced with `dL->L` view pattern - some type annotation are necessarily updated (e.g., `Pat p` --> `Pat (GhcPass p)`)
* Refactor handling of parens in types (#874)Alec Theriault2018-07-201-0/+96
| | | | | | | | | | | | | | | | | | | | | | | | * Fix type parenthesization in Hoogle backend Ported the logic in the HTML and LaTeX backends for adding in parens into something top-level in 'GhcUtil'. Calling that from the Hoogle backend fixes #873. * Remove parenthesizing logic from LaTeX and XHTML backends Now, the only times that parenthesis in types are added in any backend is through the explicit 'HsParTy' constructor. Precedence is also represented as its own datatype. * List out cases explicitly vs. catch-all * Fix printing of parens for QuantifiedConstraints The priority of printing 'forall' types was just one too high. Fixes #877. * Accept HTML output for quantified contexts test
* Match changes in GHC for #14259Alan Zimmerman2018-06-191-2/+2
|
* Match changes in GHC for TTGAlan Zimmerman2018-04-271-17/+27
|
* Match GHC for TTG implemented on HsBinds, D4581Alan Zimmerman2018-04-131-22/+22
|
* Match GHC changes for TTGAlan Zimmerman2018-04-091-7/+47
|
* Haddock: support splitted include paths. (#689)Tamar Christina2018-02-191-1/+3
|
* Fix #732 (#733)Ryan Scott2018-01-191-2/+2
|
* Track changes to follow Trac #14529Simon Peyton Jones2017-12-071-1/+30
| | | | This tracks the refactoring of HsDecl.ConDecl.
* Revert "Match changes for Trees that Grow in GHC"Ben Gamari2017-11-211-1/+1
| | | | This reverts commit 01eeeb048acd2dd05ff6471ae148a97cf0720547.
* Match changes for Trees that Grow in GHCAlan Zimmerman2017-11-071-1/+1
|
* Update for #14131Ryan Scott2017-08-231-2/+3
|
* Merge remote-tracking branch 'origin/master' into ghc-headalexbiehl2017-08-211-5/+18
|\
| * Haddock support for bundled pattern synonyms (#627)Christiaan Baaij2017-06-091-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Haddock support for bundled pattern synonyms * Add fixities to bundled pattern synonyms * Add bundled pattern synonyms to the synopsis * Store bundled pattern fixities in expItemFixities * Add test for bundled pattern synonyms * Stop threading fixities * Include bundled pattern synonyms for re-exported data types Sadly, fixity information isn't found for re-exported data types * Support for pattern synonyms * Modify tests after #631 * Test some reexport variations * Also lookup bundled pattern synonyms from `InstalledInterface`s * Check isExported for bundled pattern synonyms * Pattern synonym is exported check * Always look for pattern synonyms in the current module Another overlooked cornercase * Account for types named twice in export lists Also introduce a fast function for nubbing on a `Name` and use it throughout the code base. * correct fixities for reexported pattern synonyms * Fuse concatMap and map * Remove obsolete import * Add pattern synonyms to visible exports * Fix test * Remove corner case
| * Allow user defined signatures for pattern synonyms (#631)Alex Biehl2017-06-031-0/+5
| |
| * Make haddock-library and haddock-api warning free (#626)Alex Biehl2017-05-301-4/+0
| |
* | Rename extension index tagsAlan Zimmerman2017-06-051-7/+7
| |
* | Match new AST as per GHC wip/new-tree-one-paramAlan Zimmerman2017-06-051-13/+13
|/ | | | See https://ghc.haskell.org/trac/ghc/wiki/ImplementingTreesThatGrow
* GhcUtils: Changes for multi-pattern signaturesBen Gamari2016-07-011-1/+1
|
* Remove unused functionsMatthew Pickering2016-03-041-32/+0
|
* Fix fallout from wildcards refactoringBen Gamari2015-12-161-4/+14
| | | | | | | | | | | The wildcard refactoring was introduced a new type of signature, `ClassOpSig`, which is carried by typeclasses. The original patch adapting Haddock for this change missed a few places where this constructor needed to be handled, resulting in no class methods in documentation produced by Haddock. Additionally, this moves and renames the `isVanillaLSig` helper from GHC's HsBinds module into GhcUtils, since it is only used by Haddock.
* Matching changes for #11028Alan Zimmerman2015-12-141-3/+3
|
* Track wip/spj-wildcard-refactor on main repoSimon Peyton Jones2015-12-141-6/+6
|
* Roughly fix up haddock for DuplicateRecordFields changesAdam Gundry2015-12-141-1/+2
| | | | | This compiles, but will probably need more work to produce good documentation when the DuplicateRecordFields extension is used.
* Remove now redundant importsMateusz Kowalczyk2015-03-261-1/+0
|
* Follow API changes in D538Alan Zimmerman2015-01-231-11/+3
| | | | | Signed-off-by: Austin Seipp <aseipp@pobox.com> (cherry picked from commit d61bbc75890e4eb0ad508b9c2a27b91f691213e6)
* --package-name and --package-version flagsMateusz Kowalczyk2015-01-221-14/+0
| | | | | | Used for --hoogle amongst other things. Now we need to teach cabal to use it. The situation is still a bit sub-par because if the flags aren't passed in, the crash will occur. Closes #353.
* Support for PartialTypeSignaturesThomas Winant2014-12-121-4/+4
| | | | | | | Conflicts: haddock-api/src/Haddock/Backends/Xhtml/Decl.hs haddock-api/src/Haddock/Convert.hs haddock-api/src/Haddock/Interface/Create.hs
* Follow API changes in D426Alan Zimmerman2014-12-121-16/+17
| | | | | | | | | Signed-off-by: Austin Seipp <aseipp@pobox.com> Conflicts: haddock-api/src/Haddock/Backends/LaTeX.hs haddock-api/src/Haddock/Backends/Xhtml/Decl.hs haddock-api/src/Haddock/Convert.hs
* Changes to reflect refactoring in GHC as part of #7484Richard Eisenberg2014-12-121-0/+1
|
* Changes due to ghc api changes in package representationDuncan Coutts2014-12-121-20/+5
| | | | | | | | | | Also fix a bug with finding the package name and version given a module. This had become wrong due to the package key changes (it was very hacky in the first place). We now look up the package key in the package db to get the package info properly. Conflicts: haddock-api/src/Haddock.hs
* Revert "Merge branch 'reverts'"Mateusz Kowalczyk2014-12-121-8/+8
| | | | | | | | This reverts commit 5c93cc347773c7634321edd5f808d5b55b46301f, reversing changes made to 5b81a9e53894d2ae591ca0c6c96199632d39eb06. Conflicts: haddock-api/src/Haddock/Convert.hs
* Move sources under haddock-api/srcMateusz Kowalczyk2014-08-231-0/+304