diff options
| author | Einar Egilsson <einar@einaregilsson.com> | 2018-08-17 14:22:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-17 14:22:49 +0000 |
| commit | 0d751fc671608fcbcf20bc6da606d6df2b46e065 (patch) | |
| tree | a90b1a6a2552f9b56e7fbf4b0b832c98420599aa | |
| parent | 39f27b1eeef38978fb4f4cd0ab733e1e91ed1e8c (diff) | |
| parent | 52f9492de5ef5b95828ba0ed56ce51a8113f88b2 (diff) | |
Merge pull request #128 from gkrishnaks/master
Hide Sync option for firefox in settings page
| -rw-r--r-- | js/background.js | 2 | ||||
| -rw-r--r-- | js/controllers/redirectorpage.js | 4 | ||||
| -rw-r--r-- | redirector.html | 2 |
3 files changed, 6 insertions, 2 deletions
diff --git a/js/background.js b/js/background.js index e087c22..00ba31b 100644 --- a/js/background.js +++ b/js/background.js @@ -380,7 +380,7 @@ function sendNotifications(redirect, originalUrl, redirectedUrl ){ // So let's use useragent. // Opera UA has both chrome and OPR. So check against that ( Only chrome which supports list) - other browsers to get BASIC type notifications. - if(navigator.userAgent.toLowerCase().indexOf("chrome") > -1 && navigator.userAgent.toLowerCase().indexOf("OPR")<0){ + if(navigator.userAgent.toLowerCase().indexOf("chrome") > -1 && navigator.userAgent.toLowerCase().indexOf("opr")<0){ var items = [{title:"Original page: ", message: originalUrl},{title:"Redirected to: ",message:redirectedUrl}]; var head = "Redirector - Applied rule : " + redirect.description; chrome.notifications.create({ diff --git a/js/controllers/redirectorpage.js b/js/controllers/redirectorpage.js index e9ed30c..0386173 100644 --- a/js/controllers/redirectorpage.js +++ b/js/controllers/redirectorpage.js @@ -12,6 +12,10 @@ redirectorApp.controller('RedirectorPageCtrl', ['$scope', '$timeout', function($ return new Redirect(r).toObject(); //Cleans out any extra props, and adds default values for missing ones. } + $s.showSyncOption = false; + if(navigator.userAgent.toLowerCase().indexOf("chrome") > -1){ + $s.showSyncOption = true; + } // Saves the entire list of redirects to storage. $s.saveChanges = function() { diff --git a/redirector.html b/redirector.html index 914d32f..6a7f2a3 100644 --- a/redirector.html +++ b/redirector.html @@ -193,7 +193,7 @@ <a class="btn medium grey padded" ng-click="duplicateRedirect($index)">Duplicate</a> </div> </div> - <label id="storage-sync-option"><input type="checkbox" ng-model="isSyncEnabled" ng-click="toggleSyncSetting()" /> Enable Storage Sync</label> + <label id="storage-sync-option" ng-if="showSyncOption"><input type="checkbox" ng-model="isSyncEnabled" ng-click="toggleSyncSetting()" /> Enable Storage Sync</label> </div> <footer> |