testing, void variable resolve

4 files changed, 35 insertions, 6 deletions

diff --git a/Cask b/Cask
index a96ccfe..f92f11d 100644
--- a/Cask
+++ b/Cask
@@ -7,4 +7,7 @@
  (depends-on "f")
  (depends-on "ecukes")
  (depends-on "ert-runner")
- (depends-on "el-mock"))
+ (depends-on "ert-async")
+ (depends-on "el-mock")
+ (depends-on "request")
+ (depends-on "promise"))
diff --git a/hnreader.el b/hnreader.el
index 091fa21..e923f8d 100644
--- a/hnreader.el
+++ b/hnreader.el
@@ -1,7 +1,7 @@
+(require 'promise)
 (require 'request)
 (require 'shr)
 (require 'dom)
-(require 'promise)
 (require 'cl-lib)
 
 
@@ -19,12 +19,8 @@
      (request url
               :parser (lambda () (libxml-parse-html-region (point-min) (point-max)))
               :error (cl-function (lambda (&rest args &key error-thrown &allow-other-keys)
-                                    (message "bad")
                                     (funcall reject  error-thrown)))
               :success (cl-function (lambda (&key data &allow-other-keys)
-                                      (message "yay")
-                                      (setq thanh data)
-                                      ;; (message "%s" data)
                                       (funcall resolve data)))))))
 
 (defun hnreader--prepare-buffer (buf &optional msg)
@@ -71,8 +67,12 @@
   "Testing."
   (hnreader--prepare-buffer (hnreader--get-hn-buffer))
   (promise-chain (hnreader--promise-dom "https://news.ycombinator.com/news")
+    ;; (promise-chain (howdoyou--curl-promise-dom "https://news.ycombinator.com/news")
     (then (lambda (result)
             (message "got the dom")
             (hnreader--print-frontpage result (hnreader--get-hn-buffer))))
     (promise-catch (lambda (reason)
                      (message "catch error in promise prontpage: %s" reason)))))
+
+
+(provide 'hnreader)
diff --git a/test/emacs-hnreader-test.el b/test/emacs-hnreader-test.el
new file mode 100644
index 0000000..a2d40d6
--- /dev/null
+++ b/test/emacs-hnreader-test.el
@@ -0,0 +1,11 @@
+;;; emacs-hnreader-test.el --- Tests for emacs-hnreader
+(ert-deftest-async test/promise-dom (done)
+                   (promise-done
+                    (promise-chain
+                        (hnreader--promise-dom "https://www.google.com")
+                      (then (lambda (result)
+                              (should (listp result))
+                              ;; (message "%s" result)
+                              (funcall done)))
+                      (promise-catch done))))
+;;; emacs-hnreader-test.el ends here
diff --git a/test/test-helper.el b/test/test-helper.el
new file mode 100644
index 0000000..c0119bf
--- /dev/null
+++ b/test/test-helper.el
@@ -0,0 +1,15 @@
+;;; test-helper.el --- Helpers for emacs-hnreader-test.el
+(require 'f)
+(require 'ert-async)
+
+(defvar root-test-path
+  (f-dirname (f-this-file)))
+
+(defvar root-code-path
+  (f-parent root-test-path))
+
+(add-to-list 'load-path root-code-path)
+
+(require 'hnreader)
+
+;;; test-helper.el ends here