*.el: Avoid the obsolete `defadvice` system

* emms.el: Require `nadvice` for compatibility with Emacs<24.4.
* emms-player-vlc.el (emms-player-vlc-start): Use `advice-add` rather
than `defadvice`.

patch by Stefan Monnier

1 files changed, 6 insertions, 4 deletions

diff --git a/emms-browser.el b/emms-browser.el
index 1ae727b..fcb4ef3 100644
--- a/emms-browser.el
+++ b/emms-browser.el
@@ -190,10 +190,12 @@
 ;; artist->track instead of artist->album->track when you switch to
 ;; the 'singles' filter.
 
-;; (defadvice emms-browser-next-mapping-type
-;;                                 (after no-album (current-mapping))
-;;   (when (eq ad-return-value 'info-album)
-;;     (setq ad-return-value 'info-title)))
+;; (advice-add 'emms-browser-next-mapping-type :around #'my-emms--types)
+;; (defun my-emms--types (orig-fun &rest args)
+;;   (let ((type (apply orig-fun args)))
+;;     (if (eq type 'info-album)
+;;         'info-title)
+;;       type)))
 
 ;; (defun toggle-album-display ()
 ;;   (if (string= emms-browser-current-filter-name "singles")