diff options
| author | Yoni Rabkin <yoni@rabkins.net> | 2021-05-03 12:20:55 -0400 |
|---|---|---|
| committer | Yoni Rabkin <yoni@rabkins.net> | 2021-05-03 12:20:55 -0400 |
| commit | 4d1c998ec0be227fb038c21c0195e33a9b34457d (patch) | |
| tree | 9a665dcbad7a2acb0e5cae6449be17d3e90af5fd /emms-info-metaflac.el | |
| parent | d16d94fab0cbb9eacf909f9a6a82b078e3463513 (diff) | |
Clean: emms-track-file-p replaces eq file type checks
There were about 10 checks throughout the code checking if a track is a
file type. File type tracks are specific enough for a predicate function.
Add: EMMS warning if no tagging program for audio file type
Warn the user when there is no tag writing program available to EMMS
for modifying the actual audio files. Current behavior allows the tags
to be edited, saved to the EMMS cache db, and then silently skips past
the part where the metadata would be applied to the file itself.
The changes here prevent the user from even opening the editor for a
file that has no tag writing program configured. This can be
overridden with the prefix arg when user wants to edit the tags
anyway, knowing they will only be saved in the emms-cache-db and not
written to the source audio files.
Patch by Grant Shangreaux
Diffstat (limited to 'emms-info-metaflac.el')
| -rw-r--r-- | emms-info-metaflac.el | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/emms-info-metaflac.el b/emms-info-metaflac.el index 79131cb..f03925f 100644 --- a/emms-info-metaflac.el +++ b/emms-info-metaflac.el @@ -70,7 +70,7 @@ external metaflac program" (defun emms-info-metaflac (track) "Get the FLAC tag of file TRACK, using `emms-info-metaflac-program' and return an emms-info structure representing it." - (when (and (eq 'file (emms-track-type track)) + (when (and (emms-track-file-p track) (string-match "\\.\\(flac\\|FLAC\\)\\'" (emms-track-name track))) (with-temp-buffer (when (zerop |