*.el: Avoid the obsolete `defadvice` system

* emms.el: Require `nadvice` for compatibility with Emacs<24.4.
* emms-player-vlc.el (emms-player-vlc-start): Use `advice-add` rather
than `defadvice`.

patch by Stefan Monnier

1 files changed, 4 insertions, 3 deletions

diff --git a/emms-player-vlc.el b/emms-player-vlc.el
index 7a502cd..060f0d8 100644
--- a/emms-player-vlc.el
+++ b/emms-player-vlc.el
@@ -43,14 +43,15 @@
 ;; track, so the player sentinel has no way of telling that the next
 ;; track should be played. Therefore I redefine this low-level
 ;; function and add a "quit" track which is invisible to Emms.
-(defadvice emms-player-vlc-start (around quit-vlc-after-finish activate)
-  (let ((process (apply 'start-process
+(advice-add 'emms-player-vlc-start :override #'emms--vlc-quit-after-finish)
+(defun emms--vlc-quit-after-finish (track &rest _)
+  (let ((process (apply #'start-process
                         emms-player-simple-process-name
                         nil
                         emms-player-vlc-command-name
                         ;; splice in params here
                         (append emms-player-vlc-parameters
-                                (list (emms-track-name (ad-get-arg 0)))
+                                (list (emms-track-name track))
                                 '("vlc://quit")))))
     ;; Add a sentinel for signaling termination.
     (set-process-sentinel process #'emms-player-simple-sentinel))