aboutsummaryrefslogtreecommitdiff
path: root/emms-tag-editor.el
diff options
context:
space:
mode:
authorYoni Rabkin <yoni@rabkins.net>2021-01-20 12:45:58 -0500
committerYoni Rabkin <yoni@rabkins.net>2021-01-20 12:45:58 -0500
commitba16ff6dedf2de5dda219cf38b1d6d092b542de6 (patch)
treebcfdc7eee6d80ba88d81d68abbcc5d03e99d39f8 /emms-tag-editor.el
parent50bdbcc619e376ac2d7472b7097b3a5ba2d1f64e (diff)
* emms-tag-editor.el: lexical compatibility work
Remove free lexical variables and the add-to-list, which really should only be used for user configuration work.
Diffstat (limited to 'emms-tag-editor.el')
-rw-r--r--emms-tag-editor.el5
1 files changed, 2 insertions, 3 deletions
diff --git a/emms-tag-editor.el b/emms-tag-editor.el
index 0098024..52a8046 100644
--- a/emms-tag-editor.el
+++ b/emms-tag-editor.el
@@ -154,7 +154,7 @@ See also `emms-tag-editor-tag-file' and `emms-tag-editor-tag-ogg'.")
(require 'emms-info-metaflac)
(with-temp-buffer
(let ((tags '("artist" "composer" "performer" "title" "album" "tracknumber" "discnumber" "date" "genre" "note"))
- need val)
+ val)
(mapc (lambda (tag)
(let ((info-tag (intern (concat "info-" tag))))
(when (> (length (setq val (emms-track-get track info-tag))) 0)
@@ -544,7 +544,7 @@ Available tags are:
match "[^-]+"))
(setq compiled (concat compiled "\\(" match "\\)")
index (1+ index))
- (add-to-list 'registers (cons register index)))
+ (push (cons register index) registers))
(t (setq compiled (concat compiled (char-to-string c))))))
(if (/= paren 0) (error "Paren not match!"))
(cons compiled registers)))
@@ -830,7 +830,6 @@ A pipe is defined like below:
"Run command of pipe nameed PIPE-NAME to TRACK."
(if (eq (emms-track-get track 'type) 'file)
(let* ((coding-system-for-read 'utf-8)
- (track-name (emms-track-name track))
(command (emms-tag-editor-pipe-get pipe-name :command))
(arguments (emms-tag-editor-pipe-get pipe-name :arguments)))
(when (functionp arguments)