aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormarty hiatt <martianhiatus@riseup.net>2024-03-29 13:47:16 +0100
committermarty hiatt <martianhiatus@riseup.net>2024-03-29 13:57:26 +0100
commit608deff68713e7ea2561d0334b81a6a58e568f66 (patch)
tree1750223cecbd0600017560c55d5e624ac7b6df6f
parent1454c2253d507adf9be1d413172e0b11b853c661 (diff)
bookmarking: no move when checking bookmarked-p status
-rw-r--r--lisp/mastodon-tl.el2
-rw-r--r--lisp/mastodon-toot.el2
2 files changed, 3 insertions, 1 deletions
diff --git a/lisp/mastodon-tl.el b/lisp/mastodon-tl.el
index 4c0375d..c3147b6 100644
--- a/lisp/mastodon-tl.el
+++ b/lisp/mastodon-tl.el
@@ -1803,6 +1803,8 @@ Move forward (down) the timeline unless NO-MOVE is non-nil.
BACKWARD means move backward (up) the timeline."
(if no-move
(get-text-property (point) prop)
+ ;; NB: this doesn't differentiate absence of property from
+ ;; property set to zero, making flag props fraught:
(or (get-text-property (point) prop)
(save-excursion
(if backward
diff --git a/lisp/mastodon-toot.el b/lisp/mastodon-toot.el
index a48d5d9..d6232d5 100644
--- a/lisp/mastodon-toot.el
+++ b/lisp/mastodon-toot.el
@@ -459,7 +459,7 @@ SUBTRACT means we are un-favouriting or unboosting, so we decrement."
(interactive)
(mastodon-tl--do-if-item-strict
(let* ((id (mastodon-tl--property 'base-item-id))
- (bookmarked-p (mastodon-tl--property 'bookmarked-p))
+ (bookmarked-p (mastodon-tl--property 'bookmarked-p :no-move))
(byline-region (when id
(mastodon-tl--find-property-range 'byline (point))))
(action (if bookmarked-p "unbookmark" "bookmark"))