diff options
| author | marty hiatt <martianhiatus@disroot.org> | 2024-10-30 20:59:57 +0100 |
|---|---|---|
| committer | marty hiatt <martianhiatus@disroot.org> | 2024-10-30 20:59:57 +0100 |
| commit | 5cb2bf1c0409acb2a88f5ad45135fadb6d84db7a (patch) | |
| tree | 0944ffdd0357582dafe7f734e9464ec9b67255bc /lisp | |
| parent | 089eee64854ad6d8a880b0949fba7e2c1fb04cc6 (diff) | |
FIX #610 fix note/base toot in format-note/author byline.
non-grouped notif pagination was broken because we were propertizing
item-json and base-toot wrong. now we always hand insert-note the note
data as toot, and the status notified about as base-toot.
then we adjust our handling of this in tl--byline-author to display base
item byline correctly.
Diffstat (limited to 'lisp')
| -rw-r--r-- | lisp/mastodon-notifications.el | 12 | ||||
| -rw-r--r-- | lisp/mastodon-tl.el | 5 |
2 files changed, 9 insertions, 8 deletions
diff --git a/lisp/mastodon-notifications.el b/lisp/mastodon-notifications.el index 862f2a2..9ff8413 100644 --- a/lisp/mastodon-notifications.el +++ b/lisp/mastodon-notifications.el @@ -236,9 +236,9 @@ JSON is a list of alists." nil (mastodon-notifications--insert-note ;; toot - (if (member type '(follow follow_request)) - note ;; full notif, not just follower acct? - status) + ;; should always be note, otherwise notif data not avail + ;; later on: + note ;; body (mastodon-notifiations--body-arg type filters status profile-note follower-name) @@ -253,10 +253,8 @@ JSON is a list of alists." (t (mastodon-tl--byline-handle note nil follower-name 'mastodon-display-name-face))) - ;; base toot - (when (or (eq type 'favourite) - (eq type 'boost)) - status) + ;; base toot (always provide) + status nil nil nil type)))) (defun mastodon-notifications--format-group-note (group status accounts) diff --git a/lisp/mastodon-tl.el b/lisp/mastodon-tl.el index 6f510b3..7e37b00 100644 --- a/lisp/mastodon-tl.el +++ b/lisp/mastodon-tl.el @@ -860,7 +860,10 @@ TS is a timestamp from the server, if any." ;; NB: action-byline (boost) is now added in insert-status, so no ;; longer part of the byline. ;; (base) author byline: - (mastodon-tl--byline-author toot nil domain :base) + ;; we use base-toot if poss for fave/boost notifs that need to show + ;; base item in author byline + (mastodon-tl--byline-author (or base-toot toot) + nil domain :base) ;; visibility: (cond ((string= visibility "direct") (propertize (concat " " (mastodon-tl--symbol 'direct)) |