aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRafael Laboissiere <rafael@laboissiere.net>2019-02-21 12:08:06 +0100
committerRafael Laboissiere <rafael@laboissiere.net>2019-02-21 12:08:06 +0100
commitcc016a3ea455a3eae6ca68e668783390d2648755 (patch)
treecba7c2502e67c5211c8aaecc18557b4b5dd3a5c3
parentdf0ef432418364d4b41bdba350526ff1a67bc413 (diff)
Fix compilation warnings
* (org-recoll-search-history) Specify the type of custom variable. * (org-recoll-compare-string-to-list) Avoid warnings about assignment and reference to free variable org-recoll-matched. This is fixed by locally defining the variable inside a let construct. Furthermore, the name of the variable is changed to "matched", since there is no need to prefix it by "org-recoll-".
-rw-r--r--org-recoll.el13
1 files changed, 7 insertions, 6 deletions
diff --git a/org-recoll.el b/org-recoll.el
index 386ee45..14f4372 100644
--- a/org-recoll.el
+++ b/org-recoll.el
@@ -67,6 +67,7 @@ initated and this variable is not evaluated."
(defcustom org-recoll-search-history nil
"List to store your recoll search history."
:group 'org-recoll
+ :type 'list
)
(defcustom org-recoll-result-file-read-only t
@@ -123,12 +124,12 @@ deleting/editing parts of your research library."
(defun org-recoll-compare-string-to-list (string list)
"Compares STRING to each element of LIST."
- (setq org-recoll-matched nil)
- (while list
- (if (string= (prin1-to-string (car list)) string)
- (setq org-recoll-matched t))
- (setq list (cdr list)))
- org-recoll-matched)
+ (let ((matched nil))
+ (while list
+ (if (string= (prin1-to-string (car list)) string)
+ (setq matched t))
+ (setq list (cdr list)))
+ matched))
(defun org-recoll-fill-region-paragraphs ()
"Fill region like `org-fill-paragraph' for each para in buffer."