diff options
| author | Stefan Monnier <monnier@iro.umontreal.ca> | 2020-08-05 12:25:45 -0400 |
|---|---|---|
| committer | Stefan Monnier <monnier@iro.umontreal.ca> | 2020-08-05 12:25:45 -0400 |
| commit | ae7693ca78272d3dc577d71e55d7f9c2eed9e695 (patch) | |
| tree | 6912242153f0e22b8cf899544f02269fc93d15dd /rt-liberation-rest.el | |
| parent | 05beb9f354ed1f4600b18d88954a485536b3f8f9 (diff) | |
Adjust copyright lines; silence compiler warnings
* .gitignore: New file.
* rt-liberation-gnus.el (rt-liber-gnus-with-ticket-buffer): Move before use.
* rt-liberation-report.el: Require `rt-liberation` since it needs one
of its macros.
* rt-liberation-rest.el: Silence some compiler warnings.
(rt-liber-rest-handle-response): Use the arg instead of dynamic scoping.
* rt-liberation.el (rt-liber-reduce, rt-liber-create-tickets-string):
Fix CL's `reduce` to cl-lib's `cl-reduce`.
(rt-liber-ticket-base-retriever-parser-f): Remove stray silent backslash.
Fix CL's `copy-seq` to builtin `copy-sequence`.
(rt-liber-sort-ticket-list): Fix CL's `copy-seq` to builtin `copy-sequence`.
(rt-liber-command-set-status-deleted): Fix typo.
Diffstat (limited to 'rt-liberation-rest.el')
| -rw-r--r-- | rt-liberation-rest.el | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/rt-liberation-rest.el b/rt-liberation-rest.el index d9df8d9..7782665 100644 --- a/rt-liberation-rest.el +++ b/rt-liberation-rest.el @@ -1,6 +1,6 @@ ;;; rt-liberation-rest.el --- Interface to the RT REST API -;; Copyright (C) 2014, 2015 Free Software Foundation +;; Copyright (C) 2014-2015 Free Software Foundation, Inc. ;; ;; Authors: Yoni Rabkin <yrk@gnu.org> ;; @@ -33,7 +33,9 @@ (require 'url) (require 'url-util) - +;; (require 'rt-liberation) ; FIXME: Circular dependency +(declare-function rt-liber-parse-answer "rt-liberation" (answer-string parser-f)) +(declare-function rt-liber-ticket-base-retriever-parser-f "rt-liberation" ()) (defvar rt-liber-rest-debug-buffer-name "*rt-liber-rest debug log*" "Buffer name of debug capture.") @@ -81,7 +83,7 @@ "format=i" "&" "orderby=+Created"))) -(defun rt-liber-rest-show-string (scheme url ticket-id-list username password query) +(defun rt-liber-rest-show-string (scheme url ticket-id-list username password _query) "Return the ticket show string." (let ((user (url-encode-url username)) (pass (url-encode-url password))) @@ -168,11 +170,11 @@ "Parse the HTTP header from the server." (let ((http-ok-regexp "^HTTP.*200 OK$") (rt-ok-regexp "^rt/.*200 ok$")) - (condition-case excep + (condition-case nil (progn (re-search-forward http-ok-regexp (point-max)) (re-search-forward rt-ok-regexp (point-max))) - (error "bad HTTP response from server")))) + (error "bad HTTP response from server")))) ;FIXME: Unused string! (defun rt-liber-rest-ticketsql-runner-parser-f () "Parser function for a textual list of tickets." @@ -242,7 +244,7 @@ (defun rt-liber-rest-handle-response (buffer) "Handle the response provided in BUFFER." - (with-current-buffer response-buffer + (with-current-buffer buffer (rt-liber-rest-write-debug (buffer-string)))) (defun rt-liber-rest-edit-runner (ticket-id field value) |