Use consistent tag formatting

Puts `mapconcat' to work by defining a helper function
`sx-question--tag-format' and `concat'ing them with ` '.  Simpler, more
maintainable construction.

3 files changed, 7 insertions, 2 deletions

diff --git a/sx-question-list.el b/sx-question-list.el
index 79b07be..2fdd376 100644
--- a/sx-question-list.el
+++ b/sx-question-list.el
@@ -240,7 +240,8 @@ Used in the questions list to indicate a question was updated \"4d ago\"."
        (propertize (concat (sx-time-since .last_activity_date)
                            sx-question-list-ago-string)
                    'face 'sx-question-list-date)
-       (propertize (concat " [" (mapconcat #'identity .tags "] [") "]")
+       " "
+       (propertize (mapconcat #'sx-question--tag-format .tags " ")
                    'face 'sx-question-list-tags)
        (propertize " " 'display "\n"))))))
 
diff --git a/sx-question-mode.el b/sx-question-mode.el
index 0153feb..48c82a4 100644
--- a/sx-question-mode.el
+++ b/sx-question-mode.el
@@ -188,7 +188,7 @@ QUESTION must be a data structure returned by `json-read'."
        'sx-question-mode-date
        ;; Tags
        sx-question-mode-header-tags
-       (concat "(" (mapconcat 'identity .tags ") (") ")")
+       (mapconcat 'sx-question--tag-format .tags " ")
        'sx-question-mode-tags)
       (insert sx-question-mode-separator)
       (sx-question-mode--wrap-in-overlay
diff --git a/sx-question.el b/sx-question.el
index d3fd79f..0142929 100644
--- a/sx-question.el
+++ b/sx-question.el
@@ -73,6 +73,10 @@ With optional argument predicate, use it instead of `<'."
            (cdr (assoc property x))
            (cdr (assoc property y))))
 
+(defun sx-question--tag-format (tag)
+  "Formats TAG for display"
+  (concat "[" tag "]"))
+
 (provide 'sx-question)
 ;;; sx-question.el ends here