diff options
| author | Sean Allred <code@seanallred.com> | 2014-11-10 22:53:10 -0500 |
|---|---|---|
| committer | Sean Allred <code@seanallred.com> | 2014-11-10 22:53:10 -0500 |
| commit | 302be04d826a3f09c8cd3d313592f7976fa8c0cb (patch) | |
| tree | c1d43fff50561e86791f444307adccf3371195a1 /sx-request.el | |
| parent | 5305686182f9e233d0c4d056eab9f28a40e3932c (diff) | |
Proper GZIP testing
Test for a GZIP'd using magic bytes. See the appropriate answer on
Emacs.SE (1) for details.
(1): http://emacs.stackexchange.com/a/2978
Diffstat (limited to 'sx-request.el')
| -rw-r--r-- | sx-request.el | 28 |
1 files changed, 11 insertions, 17 deletions
diff --git a/sx-request.el b/sx-request.el index 9d9dca4..12d2b14 100644 --- a/sx-request.el +++ b/sx-request.el @@ -92,24 +92,18 @@ number of requests left every time it finishes a call.") (error "Response headers missing; response corrupt") (delete-region (point-min) (point)) (buffer-string)))) - (response (ignore-errors + (response-zipped-p (sx-encoding-gzipped-p data)) + (data (if (not response-zipped-p) data + (shell-command-on-region + (point-min) (point-max) + sx-request-unzip-program + nil t) + (buffer-string))) + (response (with-demoted-errors "`json' error: %S" (json-read-from-string data)))) - ;; If the response isn't nil, the response was in plain text - (unless response - ;; try to decompress the response - (setq response - (with-demoted-errors "`json-read' error: %S" - (shell-command-on-region - (point-min) (point-max) - sx-request-unzip-program - nil t) - (json-read-from-string - (buffer-substring - (point-min) (point-max))))) - ;; if it still fails, error outline - (unless response - (sx-message "Unable to parse response: %S" response) - (error "Response could not be read by `json-read-from-string'"))) + (unless (not (and (not response) (string-equal data "{}"))) + (sx-message "Unable to parse response: %S" response) + (error "Response could not be read by `json-read-from-string'")) ;; If we get here, the response is a valid data structure (sx-assoc-let response (when error_id |