aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShin'ya Ueoka <ueokande@i-beam.org>2017-10-26 11:56:46 +0000
committerGitHub <noreply@github.com>2017-10-26 11:56:46 +0000
commit20318b56704aba35831050f331f122c6895c1935 (patch)
treeb1716829be0ef2866def0ace05b16ca7ba30dfd9
parent40a33adf52e0767cc6ecba350112c3ded53e9355 (diff)
parent73b4bc380d1ed5f7ef61d078ffd3e4a187c3c07e (diff)
Merge pull request #96 from ueokande/QA
Testing for 0.3
-rw-r--r--QA.md23
-rw-r--r--src/content/scrolls.js4
2 files changed, 24 insertions, 3 deletions
diff --git a/QA.md b/QA.md
index f9c4109..798128e 100644
--- a/QA.md
+++ b/QA.md
@@ -92,7 +92,7 @@ The behaviors of the console are tested in [Console section](#consoles).
##### Validations
- [ ] show error on invalid json
-- [ ] show error when top-level keys has keys other than `keymaps`, and `search`
+- [ ] show error when top-level keys has keys other than `keymaps`, `search`, and `blacklist`
##### `"keymaps"` section
@@ -125,3 +125,24 @@ The behaviors of the console are tested in [Console section](#consoles).
#### Empty suggestion (#65)
- [ ] Show competions for `:open`/`:tabopen`/`:buffer` on console after closed
+
+#### Disable add-on temporary (#86)
+
+- [ ] Toggle enabled/disabled of plugin bu <kbd>Shift</kbd>+<kbd>Esc</kbd>
+
+#### URL blacklist (#90)
+
+- [ ] `github.com/a` blocks `github.com/a`, and not blocks `github.com/aa`
+- [ ] `github.com/a*` blocks both `github.com/a` and `github.com/aa`
+- [ ] `github.com/` blocks `github.com/`, and not blocks `github.com/a`
+- [ ] `github.com` blocks both `github.com/` and `github.com/a`
+- [ ] `*.github.com` blocks `gist.github.com/`, and not `github.com`
+
+#### Improve for aberration pages (#93)
+
+- [ ] able to scroll on Gmail and Slack
+
+#### Link with target='_blank' link (#94)
+
+- [ ] open link with target='_blank' in new tab by <kbd>f</kbd>
+- [ ] open link with target='_blank' in new tab by <kbd>F</kbd>
diff --git a/src/content/scrolls.js b/src/content/scrolls.js
index eda1946..a975296 100644
--- a/src/content/scrolls.js
+++ b/src/content/scrolls.js
@@ -75,9 +75,9 @@ const scrollHorizonally = (win, count) => {
const scrollPages = (win, count) => {
let target = scrollTarget(win);
- let height = target.innerHeight;
+ let height = target.clientHeight;
let x = target.scrollLeft;
- let y = target.scrollLeft + height * count;
+ let y = target.scrollTop + height * count;
target.scrollTo(x, y);
};