aboutsummaryrefslogtreecommitdiff
path: root/src/settings/components/form/KeymapsForm.tsx
diff options
context:
space:
mode:
authorShin'ya Ueoka <ueokande@i-beam.org>2019-05-05 08:03:29 +0900
committerShin'ya Ueoka <ueokande@i-beam.org>2019-05-06 22:17:18 +0900
commita0882bbceb7ed71d56bf8557620449fbc3f19749 (patch)
treef2087d44f21dd68fc3584f62cfb9b62ae58bab2b /src/settings/components/form/KeymapsForm.tsx
parentd01db82c0dca352de2d7644c383d388fc3ec0366 (diff)
Declare setting types
Diffstat (limited to 'src/settings/components/form/KeymapsForm.tsx')
-rw-r--r--src/settings/components/form/KeymapsForm.tsx23
1 files changed, 9 insertions, 14 deletions
diff --git a/src/settings/components/form/KeymapsForm.tsx b/src/settings/components/form/KeymapsForm.tsx
index ab44464..ad4d0e7 100644
--- a/src/settings/components/form/KeymapsForm.tsx
+++ b/src/settings/components/form/KeymapsForm.tsx
@@ -2,32 +2,30 @@ import './KeymapsForm.scss';
import React from 'react';
import Input from '../ui/Input';
import keymaps from '../../keymaps';
+import { FormKeymaps } from '../../../shared/SettingData';
-type Value = {[key: string]: string};
-
-interface Props{
- value: Value;
- onChange: (e: Value) => void;
+interface Props {
+ value: FormKeymaps;
+ onChange: (e: FormKeymaps) => void;
onBlur: () => void;
}
class KeymapsForm extends React.Component<Props> {
public static defaultProps: Props = {
- value: {},
+ value: FormKeymaps.valueOf({}),
onChange: () => {},
onBlur: () => {},
}
render() {
+ let values = this.props.value.toJSON();
return <div className='form-keymaps-form'>
{
keymaps.fields.map((group, index) => {
return <div key={index} className='form-keymaps-form-field-group'>
{
- group.map((field) => {
- let name = field[0];
- let label = field[1];
- let value = this.props.value[name] || '';
+ group.map(([name, label]) => {
+ let value = values[name] || '';
return <Input
type='text' id={name} name={name} key={name}
label={label} value={value}
@@ -43,10 +41,7 @@ class KeymapsForm extends React.Component<Props> {
}
bindValue(name: string, value: string) {
- let next = { ...this.props.value };
- next[name] = value;
-
- this.props.onChange(next);
+ this.props.onChange(this.props.value.buildWithOverride(name, value));
}
}